Enable tests failing due to java-joda warnings#42694
Merged
pgomulka merged 1 commit intoelastic:7.1from May 31, 2019
Merged
Conversation
Tests were failing in mixed cluster after more broad warnings were introduced in 6.x These tests were using `yyyy-MM-dd` pattern which is now warning about the change of `y` to `u`. However, using predefined pattern `strict_date` which uses the same format prevents the warning from being generate and allow smooth upgrade/work in mixed cluster. relates elastic#42679
pgomulka
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra |
Member
|
This looks good, but in the future I don't think we need a separate PR for each branch. If a PR doesn't apply to master (ie is not something that could go through master), then it can target 7.x and be backported appropriately from there. |
Contributor
Author
|
@rjernst you are right, apologies. I aimed to create a PR for 7.x and backport to 7.2 and 7.1 but forgot about the appropriate labels |
rjernst
approved these changes
May 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were failing in mixed cluster after more broad warnings were
introduced in 6.x These tests were using
yyyy-MM-ddpattern whichis now warning about the change of
ytou. However, using predefined patternstrict_datewhich uses the same format prevents the warning from beinggenerate and allow smooth upgrade/work in mixed cluster.
relates #42679
gradle check?